ci: 2,500 production-line regression guard for F11.10 (#1411) - #4709

Count production code after out-of-line test declarations

When a file declares test modules before its production implementation, exiting at the first #[cfg(test)] excludes that implementation too. This already occurs in pkgs/id/src/world_session/mod.rs: lines 49–52 declare two out-of-line test modules, followed by production code through line 2825. The guard therefore reports only 48 production lines for a file already exceeding the limit and accepts any further growth below those declarations. Exclude the attributed test items rather than assuming every test attribute starts a test-only remainder.

Useful? React with 👍 / 👎.

Fixed in fd45296 (task 6592): the counter no longer truncates at the first #[cfg(test)] — it excludes #[cfg(test)] items (inline blocks via brace counting, out-of-line declarations via their own lines only) and counts all other production lines. Verified by two independent implementations (awk + python) agreeing exactly: world_session/mod.rs 2,821, cli.rs 2,598, routes.rs 2,573, markdown.rs 5,325. The three newly-surfaced violators are grandfathered with linked split issues #4712, #4713, #4714 (markdown.rs: #4704), so the guard passes on current main and fails on any new violator. New contract test covers the early out-of-line declaration case.

End skipping when a test item's braces balance on one line

When a #[cfg(test)] item opens and closes its body on the same line, such as fn helper() {}, d is zero and the line does not end in a semicolon, so pending remains set and subsequent production items are also discarded. The new contract fixture already masks this failure: gen ... 100 5000 emits one test-only function followed by 4,999 production functions because the attribute applies only to the first function, yet the guard accepts it. Recognize a completed zero-net-depth body and add a fixture that verifies production code following it is counted.

Useful? React with 👍 / 👎.

Fixed in c2cdd94 (task 6592): skipping now ends when a test item's braces balance on the line where they opened — both when the attribute shares the line (#[cfg(test)] fn helper() {}) and when the item follows on the next line. The pending state resolves on a balanced {...} line instead of waiting for {/; forever. The contract fixture that masked this was also fixed (it now emits a real inline mod tests { ... }), and a regression fixture covers this exact shape: one-line test items followed by 2,501 production lines fail with the full count.

Exclude test-only items with compound cfg predicates

When tests are gated by #[cfg(all(test, feature = "world"))], this exact-match pattern treats the entire test module as production even though it cannot compile in a non-test build. This already affects world_limits_args_tests in pkgs/id/src/cli.rs:5068–5161, inflating the count used to justify its grandfather entry. For a non-grandfathered file using the same pattern, adding tests can incorrectly fail the production-line check. Recognize compound predicates that require test, and cover that case separately from predicates such as any(test, feature = "test-utils") that can enable production code.

Useful? React with 👍 / 👎.

Fixed in c2cdd94 (task 6592): the guard now parses the cfg predicate instead of exact-matching #[cfg(test)]. A predicate counts as test-gated when it requires a test build: exactly test, or all(...) with a top-level test-requiring arm (recursively) — so #[cfg(all(test, feature = "world"))] is excluded, while any(...) / feature-only predicates stay production. Verified on the real tree: cli.rs recounts 2,598 → 2,504 production lines (the ~94-line world_limits_args_tests block at cli.rs:5068–5161 is now excluded), still grandfathered under #4715 with the comment updated; the guard passes. Contract fixtures cover both the compound-test exclusion and a feature-only compound control that must still fail.

Ignore braces in literals and comments when locating test-item ends

When a test item contains an unmatched brace inside a string or comment, this helper treats it as Rust syntax and incorrectly extends or truncates the skipped region. This already occurs in pkgs/id/src/artifact.rs:1326, where a test appends a deliberately incomplete JSON string containing an opening {. Consequently, the test module's closing brace leaves skipdepth positive, and any production implementation added after that module is silently excluded—even if it exceeds 2,500 lines. Ignore literal/comment contents when balancing braces, and cover production code following a test module containing malformed JSON.

Useful? React with 👍 / 👎.

Fixed in 83e4b0e (task 6592): brace counting is now lexer-aware. A per-file awk scanner tracks // and /* */ comments (nested), "..." strings with escapes, raw strings r#""# (hash-count matched), and char literals (incl. escapes and \u{...}) and counts only braces in real code; the scan runs on every line so lexer state stays in sync across production regions too. Verified against the cited instance: pkgs/id/src/artifact.rs (the "{"author":"tor" test string at line 1326) — its test module now ends at its real closing brace. New contract fixture covers exactly this shape: a test module containing an unmatched "{" in a string, a "}" string, a "}" char literal, a \u{...} char, and a "}" line comment, followed by 2,501 production lines, fails with the full 2501 count. Real-tree counts are unchanged (cli.rs 2,504; markdown.rs 5,325; routes.rs 2,573; world_session/mod.rs 2,821) and the guard passes.

Recognize test declarations with trailing comments

When a test-only declaration has a trailing comment, such as #[cfg(test)] followed by mod tests; // rationale, this end-of-line semicolon check does not recognize that the item has finished. pending stays set, so a production module or multiline function immediately afterward is treated as the test item and excluded in its entirety. An otherwise over-limit production module can therefore pass the guard. Detect the terminating semicolon using comment-stripped lexical content, including in the equivalent same-line attribute branch, and add coverage for commented declarations.

Useful? React with 👍 / 👎.

Fixed in the follow-up commit (task 6592): item termination is now judged on comment-stripped lexical content instead of raw line shape. The brace scanner records the last code character and whether a code brace appeared on the line (comments, strings, raw strings, and char literals excluded), and both the stacked-attribute (pending) branch and the same-line attribute branch terminate on lastcode == ";" or a same-line brace. So mod tests; // rationale and #[cfg(test)] mod tests; // note each exclude only their own line. New contract fixture covers both forms followed by 2,501 production lines, which now fail with the full count. Real-tree counts unchanged; guard passes.